Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support StreamReadConstraints.maxDocumentLength validation for CBOR, Smile #392

Closed
pjfanning opened this issue Sep 11, 2023 · 1 comment
Closed

Support StreamReadConstraints.maxDocumentLength validation for CBOR, Smile #392

pjfanning opened this issue Sep 11, 2023 · 1 comment
Labels
2.17 cbor smile
Milestone
2.17.0

Comments

@pjfanning
Copy link
Member

pjfanning commented Sep 11, 2023 •
edited by cowtowncoder
Loading

https://github.com/FasterXML/jackson-core/blob/2.16/src/main/java/com/fasterxml/jackson/core/StreamReadConstraints.java

equivalent of FasterXML/jackson-dataformats-text#430 and #358

In particular, the 2 new ones (in 2.16)

  • maxDocumentLength
  • maxNameLength

These settings are not likely to be supported for data formats in this project. Some support already exists for the pre-existing StreamReadConstraints settings.

This issue specifically for supporting maxDocumentLength validation; #475 is for name length validation.
@pjfanning pjfanning mentioned this issue Sep 11, 2023
Open
@cowtowncoder cowtowncoder changed the title support for StreamReadConstraints Support for StreamReadConstraints for CBOR, Smile backends Sep 30, 2023
@cowtowncoder
Copy link
Member

Limited to CBOR, Smile for this issue. (as two implementations are quite similar and probably be worked on at same time).
May/should create separate ones for Avro, Protobuf, Ion; those implementations quite different so not that much shared work.

@cowtowncoder cowtowncoder changed the title Support for StreamReadConstraints for CBOR, Smile backends Support for StreamReadConstraints.maxDocumentLength for CBOR, Smile backends Jan 26, 2024
@cowtowncoder cowtowncoder mentioned this issue Jan 26, 2024
Closed
@cowtowncoder cowtowncoder added 2.17 and removed 2.16 labels Jan 26, 2024
@cowtowncoder cowtowncoder changed the title Support for StreamReadConstraints.maxDocumentLength for CBOR, Smile backends Support for StreamReadConstraints.maxDocumentLength validation for CBOR, Smile backends Jan 26, 2024
@cowtowncoder cowtowncoder changed the title Support for StreamReadConstraints.maxDocumentLength validation for CBOR, Smile backends Support StreamReadConstraints.maxDocumentLength validation for CBOR, Smile Jan 26, 2024
cowtowncoder added a commit that referenced this issue Jan 26, 2024
@cowtowncoder
Fixes #392: add max-doc-length validation for cbor, smile
3e9d2aa
@cowtowncoder cowtowncoder added this to the 2.17.0 milestone Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.17 cbor smile
Projects
None yet
Milestone
2.17.0
Development

No branches or pull requests
2 participants
@cowtowncoder @pjfanning