Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support base64 strings in getBinaryValue() for CBOR and Smile #284

Closed
wants to merge 1 commit into from

Conversation

hherman1
Copy link

Adds support for deserializing base64 strings as binary. Elasticsearch returns base64 strings
for binary fields, not native binary.

Adds support for deserializing base64 strings as binary. Elasticsearch returns base64 strings
for binary fields, not native binary.
@cowtowncoder
Copy link
Member

Sounds reasonable, although I'd probably have to check if this is similar to what other backends do (I think ParserBase has something similar already).
It would be nice to also have a unit test showing simple usage and verify correct operation?

But one request: could you rebase this against 2.13? Master branch is for Jackson 3.0 which is still some ways off, so this change would make sense for 2.13 which will be released much sooner.

@cowtowncoder cowtowncoder changed the title Support base64 strings in getBinaryValue() Support base64 strings in getBinaryValue() for CBOR and Smile Jun 27, 2021
@cowtowncoder
Copy link
Member

Thanks! I created a bit bigger patch to also support this for Smile, and for alternative access method, and for 2.13 branch.

cowtowncoder added a commit that referenced this pull request Jun 27, 2021
@hherman1
Copy link
Author

Thanks so much! Sorry I dropped this, but glad we’ll be able to remove this code from our code base! :)

@cowtowncoder
Copy link
Member

@hherman1 No problem, was easy to add just needed to have a bit of time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants