Skip to content
This repository has been archived by the owner on Jan 22, 2019. It is now read-only.

Add CsvParser.Feature.ALLOW_TRAILING_COMMA to allow enforcing strict handling #139

Merged
merged 1 commit into from
Jan 10, 2017

Conversation

nickbabcock
Copy link
Contributor

Currently the behavior allows there to be a single extraneous data column
that is empty. This is normally harmless, however, external tools that
expect the same number of data columns as header columns will complain
when this extraneous column is encountered.

The fix is to make this feature explicit and allow for it to be disabled.

This patch retains backwards compatibility by enabling the feature by
default.

I consider this a bugfix, but I may not be able to convince you 😄

Currently the behavior allows there to be a single extraneous data column
that is empty. This is normally harmless, however, external tools that
expect the same number of data columns as header columns will complain
when this extraneous column is encountered.

The fix is to make this feature explicit and allow for it to be disabled.

This patch retains backwards compatibility by enabling the feature by
default.
@cowtowncoder
Copy link
Member

@nickbabcock Thank you! I will have to think about this a bit (just came back from vacation, hence the delay), but at high level sounds reasonable.
Since it is a new feature it really should go in 2.9; it is an API add.

@cowtowncoder
Copy link
Member

Ok, looks good, will merge.

@cowtowncoder cowtowncoder merged commit 69e1f47 into FasterXML:master Jan 10, 2017
@cowtowncoder cowtowncoder added this to the 2.9.0 milestone Jan 10, 2017
@cowtowncoder cowtowncoder changed the title Add trailing comma feature Add CsvParser.Feature.ALLOW_TRAILING_COMMA to allow enforcing strict handling Jan 10, 2017
cowtowncoder added a commit that referenced this pull request Jan 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants