Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is SimpleType.withStaticTyping() correct? #765

Closed
tm2git opened this issue Apr 22, 2015 · 1 comment
Closed

Is SimpleType.withStaticTyping() correct? #765

tm2git opened this issue Apr 22, 2015 · 1 comment
Milestone
2.6.0

Comments

@tm2git
Copy link

tm2git commented Apr 22, 2015

In line 158 it passes the existing _asStatic value to the constructor for the new instance; I'm guessing that should really be the constant true.

(I was trying to figure out why neither of the suggested workarounds in #749 has any effect, and happened to notice this while single-stepping; dunno whether it's related or not).
@cowtowncoder
Copy link
Member

You are absolutely right, it's a bug. Thank you for reporting this -- I don't know if it is causing any known problems, but obviously it prevents desired behavior.

Given that there could still be unexpected side effects, I will fix this in master (for 2.6.0), and not yet 2.5.x.
This is just because it could affect handling of JAX-RS endpoints. If there are specific problems to fix, I can backport the fix.

@cowtowncoder cowtowncoder added this to the 2.6.0 milestone Apr 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

No branches or pull requests
2 participants
@cowtowncoder @tm2git