DOM Node
serialization omits the default namespace declaration
#3174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serializing xml with a default namespace (eg:
<root xmlns='http://foo'/>
) the default namespace is omitted when using theDOMImplementationLS
for serialization. This seem to be a change that has happened in the JDK around JDK11. By switching the serialization method to using the Transformer api, the default namespace is included in the xml string.The PR has a test that verifies the issue on Java15.
I didn't have java14 so I had to do some modification to build the project on my machine using Java15, so this has to be verified on your build setup before you consider merging it.