Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to avoid bogus failures wrt java8 date/time, Joda, if impl provided by mix-ins #2867

Closed
cowtowncoder opened this issue Oct 1, 2020 · 1 comment

Comments

@cowtowncoder
Copy link
Member

(for background see #2683 and #2795 )

With addition of (meant to be) helpful failure for Joda and Java 8 date/time types (latter via #2683) things work kind of ok for common case -- if no (de)serializer found for one of these types, exception given tries to suggest a solution.

Alas it appears that there is alternative means -- #2795 -- to provide for (de)serialization support with just using mix-ins, but which is not consider, so this new feature essentially breaks something that works in 2.10 and 2.11 (latter at least in 2.11.3).

It'd be good to figure out additional check to avoid this: either based on finding mix-in(s) for target type or, for deserializers, existence of non-default Creator?

@cowtowncoder cowtowncoder added to-evaluate Issue that has been received but not yet evaluated 2.12 and removed to-evaluate Issue that has been received but not yet evaluated labels Oct 1, 2020
cowtowncoder added a commit that referenced this issue Oct 1, 2020
@cowtowncoder
Copy link
Member Author

Went with "if there is a mix-in targeting specific type, do not construct failing (de)serializer": works for specific case; will deal with other problems if and when they are encountered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant