Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NioPathDeserializer improvement #2120

Merged
merged 1 commit into from
Sep 7, 2018
Merged

NioPathDeserializer improvement #2120

merged 1 commit into from
Sep 7, 2018

Conversation

remal
Copy link
Contributor

@remal remal commented Aug 23, 2018

  1. Support Windows paths on Windows OS
  2. Handle all exceptions, not only URISyntaxException
  3. If FileSystemProvider can't be found, try to find one using the current thread's context class loader

@cowtowncoder
Copy link
Member

First of all, thank you for contributing this improvement: although I am not familiar with Windows-path handling I trust it makes sense.

Before I merge this to be included in 2.9.7, just one process thing: we need a CLA, from:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the usual way is to print it, fill & sign, scan, email to info at fasterxml dot com.
Once this is done (only needs to be done once for all Jackson project contributions), I'll merge the patch.

@remal
Copy link
Contributor Author

remal commented Sep 2, 2018

Hello,

I've already done it for FasterXML/jackson-modules-java8#66

@cowtowncoder
Copy link
Member

Ah. My bad. Thanks for reminder.

@cowtowncoder cowtowncoder merged commit c570b0a into FasterXML:2.9 Sep 7, 2018
@cowtowncoder cowtowncoder changed the title NioPathDeserializer improvement NioPathDeserializer improvement Sep 7, 2018
@cowtowncoder
Copy link
Member

Thank you for contribution; this will be included in 2.9.7

cowtowncoder added a commit that referenced this pull request Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants