Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FactoryBasedEnumDeserializer should be cachable #2082

Closed
cowtowncoder opened this issue Jul 6, 2018 · 0 comments
Closed

FactoryBasedEnumDeserializer should be cachable #2082

cowtowncoder opened this issue Jul 6, 2018 · 0 comments

Comments

@cowtowncoder
Copy link
Member

Looks like regular EnumDeserializer is cachable, but it's factory-based alternative not.
I think this is not intentional but accidental; there does not seem to be particular reason to prevent it, and creation is pretty costly (I actually found it by profiling production systems).
@cowtowncoder cowtowncoder changed the title FactoryBasedEnumDeserializer not cachable, should be FactoryBasedEnumDeserializer should be cachable Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cowtowncoder