Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back TypeFactory.constructType(Type, Class) as "deprecated" in 2.7.1 #1079

Closed
cowtowncoder opened this issue Jan 13, 2016 · 2 comments
Closed

Add back TypeFactory.constructType(Type, Class) as "deprecated" in 2.7.1 #1079

cowtowncoder opened this issue Jan 13, 2016 · 2 comments
Milestone
2.7.1

Comments

@cowtowncoder
Copy link
Member

(for background, see http://stackoverflow.com/questions/34721851/spring-4-2-3-and-fasterxml-jackson-2-7-0-are-incompatible)

Due to complete rewrite of type inspection, resolution, changes were necessary to handling.
However, since some of methods removed were public and not deprecated, it would be good to go back and see if it would not be possible to add them back as deprecated in 2.7.1. While this is not as good as noticing the issue for 2.7.0, perhaps it would help reduce friction for upgrades -- it is unfortunate there was a breakage.

Related methods include:

    public JavaType constructType(Type type);
    public JavaType constructType(Type type, TypeBindings bindings);
    public JavaType constructType(TypeReference<?> typeRef);
    public JavaType constructType(Type type, Class<?> context);
    public JavaType constructType(Type type, JavaType context);

of which it is likely that 2nd one can not be supported, but others are probably fine to keep, just discarding or ignoring contextual argument.
@cowtowncoder cowtowncoder changed the title Consider adding back TypeFactory.constructType(Type, Class) in 2.7.1 Add back TypeFactory.constructType(Type, Class) as "deprecated" in 2.7.1 Jan 13, 2016
@cowtowncoder cowtowncoder added this to the 2.7.1 milestone Jan 13, 2016
@todd-richmond
Copy link

This issue also broke Swagger documentation

@cowtowncoder
Copy link
Member Author

@todd-richmond Ok good to know, in case that gets reported separately.

@cowtowncoder cowtowncoder mentioned this issue Jan 18, 2016
Closed
aryehpro added a commit to aryehpro/jackson-databind that referenced this issue Jan 25, 2016
@aryehpro
Merge branch 'master' of https://github.com/FasterXML/jackson-databind
a8d3520 
# By Tatu Saloranta (113) and others
# Via Tatu Saloranta
* 'master' of https://github.com/FasterXML/jackson-databind: (124 commits)
  Minor addition related to FasterXML#1087: resolve context type, assuming type bindings from that are expected to work.
  Add unit test for FasterXML#999
  minor warnings cleanup
  Add Javadoc badge with automatic version detection
  Fix FasterXML#1083
  Add failing test for FasterXML#1083
  add a unit test to verify that Object Id works via AtomicReference too
  Minor javadoc improvement wrt FasterXML#1076, making `SimpleType.construct(Class)` deprecated (was not yet, for some reason, should have been)
  Fix FasterXML#1078
  Fix FasterXML#1079
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release jackson-databind-2.7.0
  prepare for 2.7.0 final
  Fix FasterXML#1073
  Try to reproduce FasterXML#1074
  javadoc trimming
  Try to reproduce FasterXML#825 again, still passes.
  minor improvement to ensure base64 encoding uses configured setting
  Undo part of change done for StringDeserializer; caused issues with XML handling
  further minor cleanups to cleanup
  ...
@cowtowncoder cowtowncoder mentioned this issue Feb 3, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.1
Development

No branches or pull requests
2 participants
@cowtowncoder @todd-richmond