Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The track in a jukebox continues to play even though there is technically no music disc in it #1458

Closed
MrRedstoneToGo opened this issue Apr 21, 2024 · 6 comments
Labels
status: needs testing Issue needs testing type: bug Issue where something isn't working

Comments

@MrRedstoneToGo
Copy link

Describe the Bug

If a music disk is removed from a jukebox by a Create machine while it is still playing (only possible with Mechanical Arm and Chute, Funnels and Smart chutes are blocked by the jukebox's redstone signal), you can still hear the track. However, the jukebox no longer emits a redstone signal and the jukebox is also empty in Jade.

Reproduction Steps

  1. Put a music disc in a jukebox
  2. Remove the music disk with a chute or mechanical arm.

Expected Result

The song stops as if you were pulling out the Muaic disk by hand.

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 11

Mod Version

0.5.1f

Minecraft Version

1.20.1

Other Mods

No response

Additional Context

I took advantage of this and this is what I got. Just put a music disc on the depot and listen to the wonderful music :)

broken_pigstep.zip

There is a schematic in the zip file

@MrRedstoneToGo MrRedstoneToGo added the type: bug Issue where something isn't working label Apr 21, 2024
@TropheusJ
Copy link
Member

update FAPI

@MrRedstoneToGo
Copy link
Author

Fabric API is already installed (version 0.92.1)

@IThundxr
Copy link
Member

cant reproduce with fapi 0.92.1+1.20.1

@MrRedstoneToGo
Copy link
Author

I only tested the bug with Create Fabric and Fabric API, Fabric 0.15.10 and it was still there.

grafik

Build a tower of chutes and jukeboxes, always alternating. Maybe you can hear several pieces on top of each other.

@IThundxr IThundxr reopened this Apr 22, 2024
@MrRedstoneToGo
Copy link
Author

I have found out something more precise: When a Chute takes an item from a Jukebox, the Music Disk is removed from the Jukebox inventory, but the song is not stopped. A Mechanical Arm stops the song properly. However, there are problems if a second Mechanical wants to pick up the Music Disc from the jukebox at the same time. Then the song is not stopped.
Maybe this is related to game ticks. If the mechanical arm only searches for a target every second tick, maybe the latter bug is also fixed.

@TropheusJ TropheusJ added the status: needs testing Issue needs testing label Sep 30, 2024
@TropheusJ
Copy link
Member

This is, again, a fabric API issue. FabricMC/fabric#4220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs testing Issue needs testing type: bug Issue where something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants