Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error blame when a mixin cannot be found #998

Open
Qendolin opened this issue Nov 8, 2024 · 2 comments
Open

Improve error blame when a mixin cannot be found #998

Qendolin opened this issue Nov 8, 2024 · 2 comments

Comments

@Qendolin
Copy link

Qendolin commented Nov 8, 2024

In this case it looks like better-clouds is causing a crash, when actually morenemoswoodcuttervariants is at fault by providing an invalid name/path in it's mixins.json.
image

Since most users only read the first error (if at all), they would blame the wrong mod for the crash. In cases like these, where an error occurs during Mixin loading (not transformation), the error message could be improved by inspecting the exception cause chain.

Mods used in example:

@sfPlayer1
Copy link
Contributor

sfPlayer1 commented Nov 9, 2024

This happens because Mixin initializes when it is asked to transform the first class.

We may be able to trigger this explicitly (by calling select directly), before running preLaunch, but I'm not sure this is safe to do.

@burningtnt
Copy link

The RuntimeException occured while invoking the entrypoint of better-clouds. So wyh don't you directly think about the 'deepest' exception?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants