Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Combine laptop backlight and alpha overlay brigheness in the same slider #35

Open
WaseemAlkurdi opened this issue Apr 4, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@WaseemAlkurdi
Copy link

WaseemAlkurdi commented Apr 4, 2021

It would be nice if there was an option to give, say, the upper 50% of the slider to setting the laptop's brightness, with the lower 50% controlling the alpha overlay.
This would be far better for controlling the brightness than having two brightness controls, one being the usual slider for the overlay, and the other being Fn+F? for the panel's brightness.
I tried implementing this myself, but I didn't have an idea as to where to start.

The way this would be implemented might be something like this (pseudocode):

if (brighness slider > 50%) {
   setDisplayBrightness(full_brightness);
   setOverlayBrightness(brightness slider / 2);
} else {
   setDisplayBrightness(brightness slider / 2);
   setOverlayBrightness(0);

Thanks in advance!

@F-i-f F-i-f assigned F-i-f and unassigned F-i-f Apr 8, 2021
@F-i-f F-i-f added the enhancement New feature or request label Apr 8, 2021
@F-i-f
Copy link
Owner

F-i-f commented Apr 8, 2021

There's a pull request that implements what you requested.
However no thought has been given about how it should behave when multiple monitors are plugged in, and that's why it's not been merged.
Feel free to improve on it, this is not currently a high priority.

@WaseemAlkurdi
Copy link
Author

@F-i-f Thanks for the link!
Would something like having tabs or a source list a la https://extensions.gnome.org/extension/751/audio-output-switcher/ but with displays be a feasible fix?

@F-i-f
Copy link
Owner

F-i-f commented May 21, 2022

Quite possibly, audio-output-switch is very nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants