Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with another target #55

Open
carozo opened this issue Nov 18, 2024 · 4 comments
Open

Conflict with another target #55

carozo opened this issue Nov 18, 2024 · 4 comments

Comments

@carozo
Copy link

carozo commented Nov 18, 2024

We use this plugin to enable live activities in our app. Recently, we started using customer.io, a service that creates a NotificationServiceExtension which allows us to send rich push notifications. Both targets are created successfully on Xcode, but the rich push notifications do not show up when this plugin is active. If we remove the plugin, the rich push notifications show up as expected.
It looks like there is some sort of conflict between the targets, or a mismatch between which target should handle the notification.
Any help would be greatly appreciated. Thanks!

@carozo carozo changed the title Conflict with another widget Conflict with another target Nov 18, 2024
@EvanBacon
Copy link
Owner

Please share a repro of some sort. Also try the newest version of the plugin which has a drastically simpler implementation by leveraging new Xcode 16 features.

@Kasendwa
Copy link

Kasendwa commented Dec 6, 2024

Hi @EvanBacon the new version also doesn't resolve this matter. Let me make a repro and share. I have the same exact problem. Might be able to get one out before @carozo

@Kasendwa
Copy link

Kasendwa commented Dec 7, 2024

Hi @EvanBacon here is a repro: https://github.com/Kasendwa/expo-share-intent-bacons-apple-targets. I have a patch in there just to fix the built issue.

Just a widget built with @bacons/apple-targets and the expo-share-intent

Expected:
Both the expo-share-intent and @bacons/apple-targets modules should work together.

Happening:
When @bacons/apple-targets plugin is activated (main branch), the expo-share-intent seizes to work. Even if the build succeeds.

As shown in the screenshots below: the @bacons/apple-targets widget works (the blue thing in frame 1), and then the expo-share-intent doesn't work (in frame 3) but the app builds fine (in frame 2)

When the @bacons/apple-targets plugin is disabled (without-apple-targets branch), then the expo-share-intent plugin gets to work again (as shown in the screenshot below)

cc: @achorein incase this might be of any interest to you.

@Kasendwa
Copy link

The new release of the plugin now resolves this @EvanBacon. Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants