Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog): fix error when initially opened #10868

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix(dialog): fix error when initially opened #10868

merged 1 commit into from
Nov 26, 2024

Conversation

driskull
Copy link
Member

Related Issue: #10860

Summary

  • fix error when dialog is opened initially.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Nov 25, 2024
@driskull driskull marked this pull request as ready for review November 25, 2024 19:25
jcfranco
jcfranco approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to tweak willUpdate in addition or as an alternative. We also need automated testing for this. I'll create a follow-up issue for this.

@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Nov 26, 2024
@jcfranco jcfranco merged commit 1152ce0 into dev Nov 26, 2024
13 checks passed
@jcfranco jcfranco deleted the dris0000/dialog-fix-error-transitionEl branch November 26, 2024 07:59
@jcfranco
Copy link
Member

Created #10885.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@driskull driskull

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @jcfranco