Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the main install in CI #301

Open
psomhorst opened this issue Sep 30, 2024 · 2 comments
Open

Test the main install in CI #301

psomhorst opened this issue Sep 30, 2024 · 2 comments
Assignees
Labels
ci/cd Continuous intergration/development

Comments

@psomhorst
Copy link
Contributor

psomhorst commented Sep 30, 2024

Currently the CI build uses the [dev,publishing] install, but things should also work for the "normal install".

See #299.

(EDITED by @DaniBodor )

@psomhorst psomhorst added testing Add or modify tests ci/cd Continuous intergration/development labels Sep 30, 2024
@DaniBodor
Copy link
Member

DaniBodor commented Sep 30, 2024

Thanks for creating this issue, that was indeed an oversight. I think once we add sample data to an online repo (likely zenodo) (#302), we will rewrite/simplify build.yml, as it will no longer be necessary to run from a container. I think it's not worthwhile fixing this before then. I created #303 for that.

@DaniBodor DaniBodor changed the title CI tests only cover [dev,publishing] install Test the main install in CI Sep 30, 2024
@DaniBodor DaniBodor removed the testing Add or modify tests label Sep 30, 2024
@psomhorst
Copy link
Contributor Author

psomhorst commented Sep 30, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continuous intergration/development
Projects
None yet
Development

No branches or pull requests

2 participants