Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Use explicit types' refactoring for GetProperty #185

Open
jnm2 opened this issue Nov 3, 2018 · 0 comments
Open

'Use explicit types' refactoring for GetProperty #185

jnm2 opened this issue Nov 3, 2018 · 0 comments

Comments

@jnm2
Copy link
Collaborator

jnm2 commented Nov 3, 2018

Changes GetProperty(name, flags) to GetProperty(name, flags, null, returnType, parameterTypes, null).

In practice it's usually Type.EmptyTypes for parameterTypes but default and/or named indexers can exist and overload.

Not sure if this should be warn, info or hidden by default, but I'd probably bump it up to info or warn when using it myself.

ErikWahlstrom pushed a commit to ErikWahlstrom/ReflectionAnalyzers that referenced this issue Apr 5, 2019
There is another bug, the arguments are correct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant