Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does "contains" / "not contains" filters really works? #67

Open
sbridel opened this issue Mar 6, 2024 · 4 comments
Open

Does "contains" / "not contains" filters really works? #67

sbridel opened this issue Mar 6, 2024 · 4 comments

Comments

@sbridel
Copy link

sbridel commented Mar 6, 2024

Hello.

For instance using iris$Species dataset, either Species CONTAINS / NOT CONTAINS "set" (setosa) doesn't return anything.

Am I doing something wrong ?

I checked the dataFilter() code but i cant see any problem but I am not familiar with this type of code and IDK how I could test something to work around this..

Cheeers

EDIT: I think it's the NOT CONTAIN which is slightly weird

@sbridel
Copy link
Author

sbridel commented Mar 6, 2024

image

Only 5 setosa returned

image

@sbridel
Copy link
Author

sbridel commented Mar 6, 2024

image
it seems the not contains is broken

@sbridel
Copy link
Author

sbridel commented Mar 6, 2024

EDIT =

if (logic == "contain") {
return(ind)
# NOT CONTAIN
} else if (logic == "not contain") {
return(seq_len(ncol(values$data))[-ind])
}
}

=> change to nrow?????

@sbridel
Copy link
Author

sbridel commented Mar 6, 2024

Fixed on my fork : https://github.com/sbridel/DataEditR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant