-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to Lit, add a card editor, support for Section design and some more features and corrections. #121
Conversation
… 50%, 75%, 90% opening of shutters.
…r separation between design and behaviour ; and no more refresh bugs in config text editor.
…y of unavaible state for a device
Salut @cnico ! Par contre j'ai 2 mauvaises nouvelles pour toi. Je lui ai proposé de mettre son repo à la place du mien dans HACS mais je n'ai jamais eu de réponse. Du coup il y a 2 possibilités :
En tout cas encore bravo pour ce que tu as fait ! |
Salut @Deejayfool, Pour la suite, j'ai choisi l'option 2 afin de voir avec marcelhoogantink comment on peut merger les 2 forks dont le code est largement divergent. |
Oui j'ai fait la demande pour retirer mon repo d'HACS déjà : hacs/integration#4199 |
Hi @Deejayfool,
I propose you a contribution to this great card for shutters.
I wanted to add a few functionnalities but I was rapidly blocked by the pure increasing complexity to manage it in pure javascript. So a big change is that I converted it to the Lit framework, as it is the case for most homeassistant cards.
There are lots of code change through a huge refactoring but it was necessary to improve the maintanability of the card when adding behaviors or to fix some bugs. I was extremely precautionous not to break any design or behaviour so it should work successfully for any deployed configuration.
The added behaviours / corrections are :
Here is a list of issues that are resolved by this PR :
#116 partial closed percentage isn't show
#115 Consider adding pre-defined positions
#114 Shutter width over 153, lower strip not working
#109 feat: enable customizable texts for opened/closed
#104 why using "was opened" instead of "open"
#100 Add icon configuration
#98 New [up|down|stop]_disabled_states config to control button disabling
#93 Wrong visualization shutter image after increasing 'shutter_width_px' option
#91 It is not working anymore with HA 2023.4.2
#87 New configuration proposal: hide buttons
#79 i can not use the animation to move up or down my rolle
#76 can't install
#42 Added check for buttonsPosition hide buttons
#41 Shutter position (where do I place boolean)
#20 Added Card via HACS
I have tested it on my desktop and android mobile : I have no regression nor different behaviour compared to the version when I started to implement the modifications.
I let you test and do not hesitate to ask any question.
Another point, if it can help, I propose to become a maintainer of this card to help you, Deejayfool, on this task. If you want, we can discuss of it via discord or mails (even in French since I am frenchy).