-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate deadlock events #19139
Merged
nenadnoveljic
merged 4 commits into
master
from
nenadnoveljic/duplicate-deadlock-rows_SDBM-1325
Nov 27, 2024
Merged
Fix duplicate deadlock events #19139
nenadnoveljic
merged 4 commits into
master
from
nenadnoveljic/duplicate-deadlock-rows_SDBM-1325
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nenadnoveljic
added
team/database-monitoring
qa/skip-qa
Automatically skip this PR for the next QA
labels
Nov 26, 2024
na-ji
previously approved these changes
Nov 26, 2024
Co-authored-by: Naji Astier <[email protected]>
lu-zhengda
approved these changes
Nov 26, 2024
neko-dd
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing for docs to review as far as I can tell
nenadnoveljic
deleted the
nenadnoveljic/duplicate-deadlock-rows_SDBM-1325
branch
November 27, 2024 08:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
agent/review-requested
docs/approved
ecosystems/review-requested
product/review-requested
qa/skip-qa
Automatically skip this PR for the next QA
team/database-monitoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix duplicate deadlock events.
Motivation
The deadlock query compares the UTC deadlock timestamp with the local time, which can cause duplicate events in non-UTC databases
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged