Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate deadlock events #19139

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

nenadnoveljic
Copy link
Contributor

What does this PR do?

Fix duplicate deadlock events.

Motivation

The deadlock query compares the UTC deadlock timestamp with the local time, which can cause duplicate events in non-UTC databases

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

na-ji
na-ji previously approved these changes Nov 26, 2024
sqlserver/datadog_checks/sqlserver/deadlocks.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.35%. Comparing base (45ba4f9) to head (db0f929).
Report is 12 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
sqlserver 91.10% <100.00%> (+9.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@neko-dd neko-dd self-requested a review November 26, 2024 17:08
Copy link
Contributor

@neko-dd neko-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing for docs to review as far as I can tell

@nenadnoveljic nenadnoveljic added this pull request to the merge queue Nov 27, 2024
Merged via the queue into master with commit 26d24ec Nov 27, 2024
43 checks passed
@nenadnoveljic nenadnoveljic deleted the nenadnoveljic/duplicate-deadlock-rows_SDBM-1325 branch November 27, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants