Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving the configuration via the screen Dashticz is putting single quotes around boolean configs #310

Open
ericvb opened this issue May 1, 2018 · 5 comments

Comments

@ericvb
Copy link

ericvb commented May 1, 2018

When I take an old configuration file, I find the Boolean settings defined like this:
config['last_update'] = '0'

In the latest version, I had to change manually all Boolean settings to:
config['last_update'] = 0
to get it working.

When saving the settings via the screen, the saving code is setting again everywhere single quotes around the Booleans, causing them to not work again

@ericvb
Copy link
Author

ericvb commented May 1, 2018

Extra information: only 'false' Boolean settings are getting the single quotes...

@DewGew
Copy link
Contributor

DewGew commented Jun 12, 2018

Is this issue fixed?

@lokonli
Copy link

lokonli commented Jun 12, 2018

Yes. Issue can be closed.

@aiolos
Copy link
Contributor

aiolos commented Jun 18, 2018

The code from #328 breaks Dashticz on at least iOS10 on an iPad. (but maybe this topic on the forum is also related)

I commented the code in PR #344, I think it is related to the use of the Number() function, which is too new for the used browser versions. @lokonli can you solve this another way? There are also some other users using older browsers (which had issues before when using new JavaScript functionality).

@aiolos
Copy link
Contributor

aiolos commented Jun 21, 2018

With #344 now closed, I think this can be closed too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants