Changing RGCN/ExpGrad reshape and sampling #14
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made reshape and sampling changes discussed in #13 here, to the
03_04
notebook (using Expected Gradients onriver-dl
data).Simon and I previously found a difference in compute time that was a result of different
river-dl
data (different sequence length 360 vs 180 and number of input features 16 vs 7), so I did subset my data to match his for faster compute.This seems to work well, potentially with a less strong exact convergence (see the cellblock plotting
expected_gradiants_ls1
vsexpected_gradiants_ls2
), but both notebooks are showing consistent/near-identical results (i.e., I'm not concerned about it)