Add "Entity Inventory" option to entity aspects on world item tunnels #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an "Entity Inventory" option to aspects on world item tunnels that interact with entity inventories, to specify if the default "sided" method should be used to select the inventory type, or if a specific inventory type should be used. Currently implemented options are "sided" (current behaviour), "armor", and "inventory" (could be renamed to "main inventory" or "main"). Possible additional options include "ender"/"ender inventory", to allow the world item tunnels to access the ender chests of players.
From a technical standpoint; adds a registry that is used to determine the
IItemTargetused by the world item tunnel based on various properties. The current proxies in the registry work solely based on theWorld.PROPERTY_ENTITYINVENTORYIAspectProperty. The reason for using a registry over other more direct methods is for InTu-Compat to be able to add extra proxies to the registry; see issue #2 on InTu-Compat.