Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore old exact quantity aspect property movement semantics #216

Open
rubensworks opened this issue Mar 3, 2021 · 5 comments
Open

Restore old exact quantity aspect property movement semantics #216

rubensworks opened this issue Mar 3, 2021 · 5 comments

Comments

@rubensworks
Copy link
Member

Issue type:

  • ➕ Feature request

Short description:

Currently, the check stack size property only allows movement of exactly the given quantities (can span across multiple slots).
The old exact quantity semantics meant that it only allows movement of exactly the given quantities within a single slot (can NOT span across multiple slots).

Given the niche usage scenario's for exact quantity, I don't consider this feature very urgent.

Originally reported in #215 and handled in 6549b16.

@rubensworks
Copy link
Member Author

Thanks for the suggestion!

@7eggert
Copy link

7eggert commented Aug 20, 2021

The commit is bad. Now it transfers less than the exact quantity, too. Also it removed the option to make exact transfers from all entries even if check stack size was not available.

I think the solution is bad anyway. It should have a max. transfer size and a granularity. E.g. transfer up to 36 items but 9, 18, 27 and 36 are OK.

IntegratedTunnels-1.16.5-1.8.5.jar

@rubensworks
Copy link
Member Author

So the check stacksize option does not work for you?

@7eggert
Copy link

7eggert commented Aug 20, 2021

On the entries that offer "check stack size" it did work, but most entries did not have that option to begin with.

E.g. "Export all items":

  • Channel
  • Round-Robin
  • Item Transfer Rate
  • Item slot
  • Passive Interaction

No "check stack size".

I just tested it with a multiservo press (Thermal):
Chest → Export Item, card = empty item card, transfer rate = 9, Slot = -1, Check Stack Size = true, Empty is wildcard; rest unchanged.

Put two charcoal into the chest, each being one stack. Both are inside the Multiservo Press.

Test again, Slot = 0: Same.

@rubensworks
Copy link
Member Author

It makes sense that export all items does not have this option, as there is nothing to compare the stack size against.

If you think there is a bug, please open a bug report.

@rubensworks rubensworks moved this to Options in Features Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Options
Development

No branches or pull requests

2 participants