Improve WTextField #140
Merged
Improve WTextField #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also deprecated the public getCaretPos method since it was public.
Introduce CTRL+(Left/Right) for deletes, selects and cursor moves.
|
This shouldn't have any breaking API changes, but at this point im a bit too tired to be sure 😅 |
Juuxel
requested changes
Nov 12, 2021
src/main/java/io/github/cottonmc/cotton/gui/widget/WTextField.java
Outdated
Show resolved
Hide resolved
Juuxel
approved these changes
Nov 16, 2021
|
Thanks for this, I'm going to clean up some rough edges here and merge it to the 1.18 pres too a bit later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fixes #139
Functionality changes made to
WTextField: