CONCORE on Windows

[Rahuljagwani]

@pradeeban

There is a major issue for Concore on Windows as commands used in building concore are favorable for unix systems. As one can notice in .bat files (example makestudy.bat) python3 command is used which is not suitable for windows and commands like xterm, ln are used in many places (debug.bat etc. files).

Moreover in https://github.com/ControlCore-Project/concore/blob/main/fri/server/main.py call is made to makestudy, build etc. in such a way that it will give error on windows.

So I propose working on same. As lot of files need to be changed and to identify if it is expected behavior or not, I have raised this issue on discussions rather than directly creating issue.

I already mentioned this in #30 before but no one responded.
Looking forward to working on it.

Thank You

[pradeeban]

There is an open PR from Parteek on this. Can you check whether that addresses this issue?

I am aware we mostly tested on Mac OS and Linux and issues are likely on Windows.

[pradeeban]

Tested the PR. It breaks the execution on MacOS. Your observation is right.

Let's hold on this for a while. We can start on this with the GSoC. This is not a trivial issue to fix (or to test the fixes).

[parteekcoder]

There is an open PR from Parteek on this. Can you check whether that addresses this issue?
I am aware we mostly tested on Mac OS and Linux and issues are likely on Windows.

Actually that is half part of issue, .bat files must also be modified. The commits made by Parteek are in favor of only windows (as unix code is removed, now only will work for windows but not for Linux and Mac OS). Therefore, it has to be done properly.

Before making an PR i tested this both on windows and MAC OS it was running fine , but don't know why this error coming now
But i will look for it

[parteekcoder]

Now I find One solution that we can identify OS name using os.name

posis: his is the name for UNIX-like operating systems (including Linux and macOS).
nt: This is the name for the Windows operating system.

And then we can put commands in if block like this
if posis:
proc = call(["./makestudy", makestudy_dir], cwd=concore_path)
if nt:
proc = call(["makestudy", makestudy_dir], shell=True,cwd=concore_path)

will look for more better solutions

[pradeeban]

That if-else approach looks good to me. But my suggestion is to wait on that. It will need a lot of testing and is modifying the core of concore. So we need to be extra-careful.

[parteekcoder]

Ok @pradeeban do you want me to implement make a PR, Which will wait for acceptance in GSOC

As I have seen at many place people checks for different os using if else and make decision

[Rahuljagwani]

@pradeeban I tested the PR made by @parteekcoder.
It was not working on linux, macos . On windows also there was a little problem. Some batfiles has to be changed for windows. I am shortly sending a PR regarding the same. You can test it, it will be working on all Platforms.

[pradeeban]

Great, thanks.

You can implement and include the PRs (that are open, closed, and closed-without-merging) in your proposals (hope we get accepted to GSoC 2023) too. Some PRs, I will take longer (such as the ones to this issue), and I will discuss with other contributors before the merge.

[pradeeban]

Thanks, @Rahuljagwani and @parteekcoder, for your contributions and testing.