-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:add rpc debug_traceCallMany #2974
base: master
Are you sure you want to change the base?
feat:add rpc debug_traceCallMany #2974
Conversation
Can one of the admins verify this patch? |
test this please |
retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r1, all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @xiehou3131)
crates/client/src/rpc/traits/eth_space/debug.rs
line 44 at r1 (raw file):
#[rpc(name = "debug_traceCallMany")] fn debug_trace_call_many( &self, requests: Vec<TransactionRequest>,
seems the API definition is not compatible with ethereum impl, recommend keep consistent in api level https://docs.chainstack.com/reference/base-tracecallmany and the state override can leave not implemented, but api should be same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 8 files at r2, all commit messages.
Reviewable status: 7 of 8 files reviewed, 3 unresolved discussions (waiting on @xiehou3131)
crates/rpc/rpc/src/debug.rs
line 211 at r2 (raw file):
"num", )?; request.nonce = Some(nonce);
because there are multiple requests, so the nonce maybe need manually manage by the code, not directly get from state
crates/client/src/rpc/impls/eth/debug.rs
line 85 at r2 (raw file):
bundle: Bundle, simulation_context: SimulationContext, // state_override: Option<StateOverride>,
these code can be deleted
This change is