Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Uniswap v1 protocol introduction #741

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

jackleeio
Copy link
Contributor

Pre-flight checklist

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
conflux-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2024 9:32am

@0xn1c0 0xn1c0 self-requested a review September 27, 2024 14:02
Copy link
Collaborator

@0xn1c0 0xn1c0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested some small change on title

@0xn1c0
Copy link
Collaborator

0xn1c0 commented Sep 27, 2024

@darwintree @jackleeio I'm not sure if this content is actually useful or relevant. Which is the purpuse of this "Protocols Introduction Section"? Who is it aimed to? I'd like to know if you have any comments on why you think this content should be here.
Probably a tutorial on how to deploy your own uniswap v1 protocol on conflux would be a lot more relevant for this webpage.

@jackleeio
Copy link
Contributor Author

Which is the purpuse of this "Protocols Introduction Section"? Who is it aimed to? I'd like to know if you have any comments on why you think this content should be here.

This content was added based on the previous suggestion:#664 (comment), and the basic introduction of these protocols is mainly aimed at general users and beginner blockchain developers in the Conflux ecosystem.

Probably a tutorial on how to deploy your own uniswap v1 protocol on conflux would be a lot more relevant for this webpage.

As for this part, I think it would be good to create an additional tutorial and place it in the tutorial folder

@0xn1c0
Copy link
Collaborator

0xn1c0 commented Sep 30, 2024

Ok ok, it makes sense, thanks for the clarification!

@0xn1c0 0xn1c0 merged commit a34dc47 into Conflux-Chain:main Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants