Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Server Builder - Create System Assigned Identity #1094

Open
kevinferretti opened this issue Jan 30, 2024 · 3 comments
Open

SQL Server Builder - Create System Assigned Identity #1094

kevinferretti opened this issue Jan 30, 2024 · 3 comments

Comments

@kevinferretti
Copy link

Thanks for all your work on this awesome project.

I would like to create a system assigned managed identity for my SQL Server as part of the sqlServer builder but that doesn't seem to be possible. I'm willing to put in a PR for this if this is something that you would like to support.

@martinbryant
Copy link
Contributor

Hi @kevinferretti

Would you mean something similar to the grant_access on the storageaccount builder where you can provide a PrincipalId and a RoleId? If so it seems like this would be a good thing to do.

@kevinferretti
Copy link
Author

@martinbryant I was thinking something similar to the system_identity flag on the functions builder.

@ninjarobot
Copy link
Collaborator

@kevinferretti the resource supports it so this should be doable, and we'd appreciate the contribution!

You'll need to add an Identity field to the IArmResource, similar to how Sites does it for function apps.

Then it needs to be implemented in the JsonModel so it will be emitted in the template. You can also look to the implementation in function apps.

So it can be set from the builder, you'll need to add a field on the builder's config object (example from web apps).

And finally the add_identity operation and the system_identity operation. These will be a little simpler for SQL Server since you don't need to wrap them like it needed for the web apps.

Please give it a try, and reach out if you need help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants