New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a configuration for defining success/error/notify routes #10

Open

3 tasks

jakubtobiasz opened this issue Sep 4, 2024 · 0 comments

Open

3 tasks

Create a configuration for defining success/error/notify routes #10

jakubtobiasz opened this issue Sep 4, 2024 · 0 comments

Labels

Milestone

Member

jakubtobiasz commented Sep 4, 2024 •

edited

Loading

In #4 I've created the following parameters:

commerce_weavers_tpay.payum.create_transaction.success_route
commerce_weavers_tpay.payum.create_transaction.error_route
commerce_weavers_tpay.payum.create_transaction.notify_route

Despite it probably won't be changed by anyone, we should provide a dev-friendly way of configuring it. E.g.

commerce_weavers_tpay:
    payum:
        create_transaction:
            success_route: 'some_other_route'
            # etc.

Small wins 🏆

commerce_weavers_tpay.payum.create_transaction.success_route can be configured via a configuration
commerce_weavers_tpay.payum.create_transaction.error_route can be configured via a configuration
commerce_weavers_tpay.payum.create_transaction.notify_route can be configured via a configuration

The text was updated successfully, but these errors were encountered:

jakubtobiasz mentioned this issue

Handle notifications sent from the Tpay #12

Merged

jakubtobiasz added this to the 0.3 milestone

jakubtobiasz added enhancement dx labels

lchrusciel modified the milestones: 0.3, 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment