Fix evalution issue with PredicateArgumentEvaluator. #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `evaluateSense` method requires attributes as part of the evaluation. - `evaluate` methods remotes attributes in the gold and predicted views. - Calling `evaluate` before `evaluateSense` causes the evaluation to fail as the attributes are missing now.
|
Nice catch. I think I fixed it in #215 but it's not checked in. |
|
Feel free to merge. |
|
Its not fixed in #215. I ran with the changes in that branch and the issue still happens. |
|
Then I guess I forgot to commit the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
evaluateSensemethod requires attributes as part of the evaluation.evaluatemethods remotes attributes in the gold and predicted views.evaluatebeforeevaluateSensecauses the evaluation to fail as the attributes are missing now.