New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in WNSim #677

Open

mssammon opened this issue Aug 3, 2018 · 0 comments

Assignees

Contributor

mssammon commented Aug 3, 2018

duplicate call for two supposedly different scores:
https://github.com/CogComp/cogcomp-nlp/blob/master/similarity/src/main/java/edu/illinois/cs/cogcomp/wsim/wordnet/PathFinder.java#L163
presumably, supposed to consider both directions for the relationship by default (i.e. rel(w1, w2) and rel(w2, w1) which makes sense if the wn relations specified for the call are asymmetric -- which they presumably are.

verify intent of wnsim() behavior.
evaluate change on relevant test set.
parameterize to make bidirectional comparison a choice (right now there isn't and it is OK because of the bug described above; but client should have the choice of asymmetric/symmetric function)

cogcomp-dev self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment