Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HorseBuff Causing Lag #42

Open
muhammedesadcomert opened this issue May 4, 2023 · 10 comments
Open

HorseBuff Causing Lag #42

muhammedesadcomert opened this issue May 4, 2023 · 10 comments
Labels
bug Something isn't working

Comments

@muhammedesadcomert
Copy link

muhammedesadcomert commented May 4, 2023

HorseBuff mod causing incredible lag while on a horse. You can see Failed to handle packet error in the logs.

Minecraft: 1.19.4
Mod: 2.0.4

Logs: https://mclo.gs/CYEEmNP

@CodeF53
Copy link
Owner

CodeF53 commented May 5, 2023

Have you tried removing it to make sure it's actually horsebuff?

HorseBuff doesn't touch any networking or packet code, which is what the errors are mentioning.

@muhammedesadcomert
Copy link
Author

Of course, I tried it, and the lag is gone. I haven't had enough time yet to test it in an isolated modpack. It may be a mod incompatibility issue.

@allanonmage
Copy link

Did you ever track down what the lag was about?

@CodeF53
Copy link
Owner

CodeF53 commented Jun 16, 2023

I reformatted my pc and I haven't bothered to set up my mod development environment since then.

I haven't played minecraft in months, so I don't have much motivation to update my mods.

@muhammedesadcomert
Copy link
Author

I reformatted my pc and I haven't bothered to set up my mod development environment since then.

I haven't played minecraft in months, so I don't have much motivation to update my mods.

Are you open for pull requests? I would like to contribute this mod.

@CodeF53
Copy link
Owner

CodeF53 commented Jun 16, 2023

Are you open for pull requests? I would like to contribute this mod.

I am absolutely open to pull requests!

Only request is that you enable the github actions on your fork so I don't have to fuss around with git inorder to test your code.

@muhammedesadcomert
Copy link
Author

Ok, that's cool!

Workflows will be run.

@allanonmage
Copy link

I was sad when you said you were abandoning it, but now I'm happy that someone will update it. I've been trying to be particular about mods I'm adding to a modpack to make sure they will get updates.

@CodeF53 CodeF53 added the bug Something isn't working label Jul 12, 2023
@Sandr-aa
Copy link

I came to have come across the same problem, disabling Fix Rubberbanding on Stairs is an workaround

@somykOS
Copy link

somykOS commented Dec 6, 2024

mod version 2.1.8, still has this issue.
thanks to @Sandr-aa for commenting how to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants