mctpd: Set initial route MTU to interface minimum #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Couple of minor things:
Might be good to clarify this with "link" (or "interface") rather than "device". In the previous paragraph, "device" refers to the remote endpoint. Could you add a signed-off-by too? This probably warrants changelog entry as well, as it may trigger application changes. |
mkj
added a commit
that referenced
this pull request
Aug 30, 2024
This is an attempt to fix "RuntimeError: Event loop is closed" seen in #51 Signed-off-by: Matt Johnston <[email protected]>
jk-ozlabs
reviewed
Aug 30, 2024
Initial MTU is set to max_mtu to match the Linux driver. These are expected in all interfaces reported by the kernel. Tests will fail without this once mctpd starts using IFLA_MIN_MTU and IFLA_MAX_MTU. Signed-off-by: Matt Johnston <[email protected]>
This allows better compatibility with devices that have a low initial allowed packet size and require application negotiation to increase that packet size. Previously the MTU was left at 0, so matching the currently set MTU of the interface. Signed-off-by: Matt Johnston <[email protected]>
mkj
force-pushed
the
pr/initial-min-mtu
branch
from
81018a1 to
7a33524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows better compatibility with devices that have a low initial allowed packet size and require application negotiation to increase that packet size.
Previously the MTU was left at 0, so matching the currently set MTU of the device.