Improve checks for MCTP control protocol messages #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have some improvements in mind for this, converting to draft. |
jk-ozlabs
force-pushed
the
pr/resp-checks
branch
from
f87bec1 to
473126a
Compare
jk-ozlabs
force-pushed
the
pr/resp-checks
branch
from
473126a to
13ff37d
Compare
Currently we ignore the IID and opcode fields in control protocol response messages. This means we may get a delayed response from an endpoint, it may be interpreted incorrectly as a response to the next message. Instead, allocate new IIDs for each message, then check the IIDs in responses. We do this through a new common response validation function, mctp_ctrl_validate_response. This requires some additional string building for error messages. Signed-off-by: Jeremy Kerr <[email protected]>
jk-ozlabs
force-pushed
the
pr/resp-checks
branch
from
13ff37d to
e7d64b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series implements more checking on MCTP control protocol responses: that they have the correct opcode and IID values from the request.
In doing so, we use a common error checking path.