Type support #29
Open
Type support #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Young <[email protected]>
Signed-off-by: Adam Young <[email protected]>
|
I see now that this pretty much echos the "generic" MR which is better documented, and has some feed back. I will merge in this effort with that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type code had been hard-coded to 0, which is for MCTP command messages. However, SPDM requires a type code of 5. this adds a command line parameter to set the type code. It leaves the default as 0 if the type parameter is absent.
The second commit removes the error message that comes back if the request and response are not parallel in size. This check is only relevant for echo messages, and does not apply for MCTP command or SPDM messages.