Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mctp-req cannot handle control messages. #20

Open
admiyo opened this issue Nov 3, 2023 · 2 comments
Open

mctp-req cannot handle control messages. #20

admiyo opened this issue Nov 3, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@admiyo
Copy link

admiyo commented Nov 3, 2023

IN order to test against a live MCTP server, we need a request tool that is more flexible than just an echo request. Specifically:

  1. The client needs to be able to specify the type code in the header. Currently that is hard coded to 1, but MCTP control messages (needed for baseline testing ) are 0. SPDM messages are type 5.
  2. The client assumes it is sending an echo packet, and confirms the length and fields accordingly. This is not used for any actual server and should become alternate, not default behavior.
  3. The output should be parsable, which means that non-payload output should be suppressible.
@admiyo
Copy link
Author

admiyo commented Nov 3, 2023

To address point 1, (the type field), I used modified my version to have a type command line parameter. If this parameter is missing, it defaults to 1, so existing behavior is maintained.

@jk-ozlabs
Copy link
Member

So mctp_req and mctp_echo were originally intended just for testing the kernel MCTP stack - where the type/content/etc of the message data wasn't important at all - just that we could get a message sent and a reply received.

If you want to turn mctp_req into a more generic tool for creating MCTP messages, that's fine; there's no real need to keep current behaviour if it causes problems with new code - as long as we have some way to test a simple request/response message through the AF_MCTP transport.

@jk-ozlabs jk-ozlabs added the enhancement New feature or request label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants