-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notepad-plus-plus revert "Update uchardet to 0.0.6 ..." #80
Comments
|
I don't see how #74 helps on this, but it would be nice if we haven't this issue. Reverting the uchardet changes (#52) sounds like a bad idea anyway.
That's horrible! .NET is 90% Windows? Any idea how to start fixing this? |
I didn’t mean to cancel, but to try to improve on the basis of the knowledge gained :)
I think there have been changes breaking the encodings from the win32 API (sorry, but I don’t know how they got the encoding). For example, https://github.com/alberto-dev/notepad-plus-plus/commit/a504ebba54c41309f42006f8d82ecea435085731#diff-ada290d05258a2a91d5a3e19690f89acL340 Perhaps there were some other changes, in addition to the names of the encodings, which affected badly
Start by correcting the encoding names: #75. And then how it goes :) |
Take a look. Thus, new encoding detections were deleted (notepad-plus-plus/notepad-plus-plus@9a39faf#diff-7c6715d4fafa723d6682f3b295c32875L82) This allowed us to discard cases when the same metrics arise (#77 (comment)) |
Hello!
notepad-plus-plus revert "Update uchardet to 0.0.6 to improve UTF-8 detection quality" -- notepad-plus-plus/notepad-plus-plus#5414
We need to look and fix the corresponding changes, since after #52 we got a lot in common (now #74 looks like the beginning of a solution)
The text was updated successfully, but these errors were encountered: