Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UTF-8 with emojis detected as pure ascii with 100% confidence #161

Open
piranna opened this issue Jul 7, 2023 · 0 comments
Open

UTF-8 with emojis detected as pure ascii with 100% confidence #161

piranna opened this issue Jul 7, 2023 · 0 comments

Comments

@piranna
Copy link

piranna commented Jul 7, 2023

I think here there are two bugs:

  1. a pure ascii string (0x00-0x7F) is also a valid UTF-8 string, so it should detect both of them, if not with a 100% confidence maybe a 99% for the UTF-8 case to give priority to the ascii one
  2. if text has emojis or any code sequence outside of the ones of pure ascii, definitely it's NOT a pure ascii string
piranna added a commit to Mafalda-SFU/textlint-rule-editorconfig that referenced this issue Jul 7, 2023
@piranna
HACK: ASCII is a subset of UTF-8, so we don't need to report it
ced0b6a 
See CharsetDetector/UTF-unknown#161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@piranna