How about changing the Shift-JIS codepage name to shift_jis

[puran1218]

It seems shift-jis is not a common use name of the Shift-JIS codepage. How about changing the Shift-JIS codepage name to shift_jis?

• Microsoft using shift_jis https://docs.microsoft.com/en-us/dotnet/api/system.text.encodinginfo.name?view=net-5.0
• Mozilla Charset Detectors using Shift_JIS https://www-archive.mozilla.org/projects/intl/chardet.html
• Wikipedia using shift_jis https://en.wikipedia.org/wiki/Code_page_932_(Microsoft_Windows)
• chardet/chardet using Shift_JIS
• uchardet/uchardet using Shift_JIS
• I found one place is using shift-jis as its label, but the name is still shift_jis https://encoding.spec.whatwg.org/#shift_jis

The change will affect two places: shift-jis -> shift_jis

1. UTF-unknown/src/Core/CodepageName.cs

   Line 151 in 43623b7

   internal const string SHIFT_JIS = "shift-jis";

2. UTF-unknown/README.md

   Line 102 in 43623b7

   | Japanese | `iso-2022-jp`, `shift-jis`, `euc-jp` |

[304NotModified]

Sounds good to me, but I guess it's a (semantic) breaking change?

[rstm-sf]

We can check this for the rest of the names as well. Here's an example for shift_jis

https://github.com/dotnet/runtime/blob/547b2018a9013e18a9128478355380796d7ebccd/src/libraries/System.Text.Encoding.CodePages/tests/EncodingCodePages.cs#L87-L94

[304NotModified]

I think also that shift_jis is better, but any proposal to change it without breaking others? (E.g. code build on shift-jis)

[rstm-sf]

Sorry, but I didn't quite understand the question :)

For the creation of the Encoding object, this shouldn't be affected, in my opinion.

This will only affect the EncodingName

UTF-unknown/src/DetectionDetail.cs

Line 57 in 43623b7

public string EncodingName { get; }

[304NotModified]

This is an issue:

if(encoder.Detected?.EncodingName == "shift-jis")
{
...
}

As it will be "shift_jis".

I think this is a good idea, but because it's a semantic breaking change, it should wait for v3