Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verifying remote signing / web3signer #7174

Open
franjoespejo opened this issue Oct 17, 2024 · 2 comments
Open

verifying remote signing / web3signer #7174

franjoespejo opened this issue Oct 17, 2024 · 2 comments
Labels
meta-feature-request Issues to track feature requests.

Comments

@franjoespejo
Copy link

franjoespejo commented Oct 17, 2024

Problem description

Lodestar already implements the w3signer standard https://chainsafe.github.io/lodestar/run/validator-management/external-signer

The standard assumes the w3s trusts the validator client, since there is no way for the w3s to verify the payload to be signed.

Solution description

The proposal to fix that is: ethereum/remote-signing-api#10

Nimbus has implemented this: https://nimbus.guide/web3signer.html#verifying-web3signer, it is specially useful for diva which distributes the w3s signatures.

@franjoespejo franjoespejo added the meta-feature-request Issues to track feature requests. label Oct 17, 2024
@nflaig
Copy link
Member

nflaig commented Oct 18, 2024

I am curious what's the expected / best UX for this, in the Nimbus docs it is noted that you have to set an extra flag

You can instruct Nimbus to use the verifying Web3Signer protocol by either supplying the --verifying-web3-signer command-line option

but I don't think this should be required as you could determine based on /api/v1/eth2/sign/{pubkey} if for that specific pubkey / remote signer proofs should be provided or not (based on block_properties).

I am wondering if it's useful to enforce to only send verified message via such a flag but on the other hand it's the w3s that needs to enforce it and reject requests without proofs.

@nflaig
Copy link
Member

nflaig commented Oct 19, 2024

@franjoespejo something else to consider, the keymanager api allows to manage remote signer keys, should consider updating that as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-feature-request Issues to track feature requests.
Projects
None yet
Development

No branches or pull requests

2 participants