Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish traduction #14

Open
manutortosa opened this issue Dec 9, 2023 · 10 comments
Open

Spanish traduction #14

manutortosa opened this issue Dec 9, 2023 · 10 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@manutortosa
Copy link

Since the last update ( i had 1.2.2.2 and now 1.2.2.6) i get by default strings in FRENCH, my TV language is set to SPANISH, it should default to ENGLISH maybe?. Also i can help translating into Spanish if you are interested.

@Cathwyler Cathwyler self-assigned this Dec 9, 2023
@Cathwyler Cathwyler added bug Something isn't working enhancement New feature or request labels Dec 9, 2023
@Cathwyler
Copy link
Owner

Cathwyler commented Dec 9, 2023

I already fixed the localization last week in this commit
I was waiting to get the app working on Webos 2.X before draft a new release but it is taking more time than i expected.
The release 1.2.2.7 should have localization working again.

For sure if you want to translate to spanish, i will gladly accept it.

You need to translate this file for the TV App
https://github.com/Cathwyler/MagicRemoteService/blob/master/MagicRemoteService/Resources/TV/MagicRemoteService/appstring.json

And for the PC App it is a bit more complicated. You need to translate these files but only the texts in "value" tag framed in "data name=*.Text"
https://github.com/Cathwyler/MagicRemoteService/blob/master/MagicRemoteService/Properties/Resources.fr.resx
https://github.com/Cathwyler/MagicRemoteService/blob/master/MagicRemoteService/BindCreator.fr.resx
https://github.com/Cathwyler/MagicRemoteService/blob/master/MagicRemoteService/Setting.fr.resx
https://github.com/Cathwyler/MagicRemoteService/blob/master/MagicRemoteService/TV.fr.resx

English texts are respectively in
https://github.com/Cathwyler/MagicRemoteService/blob/master/MagicRemoteService/Properties/Resources.resx
https://github.com/Cathwyler/MagicRemoteService/blob/master/MagicRemoteService/BindCreator.resx
https://github.com/Cathwyler/MagicRemoteService/blob/master/MagicRemoteService/Setting.resx
https://github.com/Cathwyler/MagicRemoteService/blob/master/MagicRemoteService/TV.resx

Just send me back these translated files and i will add them in a future release.

Regards

@manutortosa
Copy link
Author

manutortosa commented Dec 9, 2023 via email

@Cathwyler
Copy link
Owner

For the PC app you can obviously also do it directly with Visual Studio if you know how to do it

@manutortosa
Copy link
Author

manutortosa commented Dec 10, 2023 via email

@manutortosa
Copy link
Author

manutortosa commented Dec 10, 2023 via email

@Cathwyler
Copy link
Owner

I didn't receive the attachment.
You can drag and drop it on github.

@manutortosa
Copy link
Author

Sent as ZIP as GitHub doesn't accept .resx ones.
Spanish translations.zip

@Cathwyler
Copy link
Owner

Added spanish translation 1.2.2.8
I google some missing trad

Let me know if it works fine

@manutortosa
Copy link
Author

It works perfectly in both PC and TV, there's 2 strings to improve ("Dejar" should be "Salir", one "Si" should be "Aceptar" in the context and some other) will send a improvement soon, also the PC component, in the "PC" tab, the millisecconds field partly covers the text, the rest looks amazing.

@Cathwyler Cathwyler changed the title French strings Spanish traduction Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants