Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should dependency scanning in DependencyContextAssemblyCatalog consider transitive deps? #360

Open
ethankershaw opened this issue Jul 29, 2024 · 0 comments

Comments

@ethankershaw
Copy link

While working on ethankershaw/fix-11 I was puzzled why I was needing to manually add the modules via configurator instead of them being picked up by scanning. I debugged it and determined that the Carter.SirenNegotiator.Samples project was getting it's Carter reference transitively through the Carter.SirenNegotiator project reference. Carter.DependencyContextAssemblyCatalog.IsReferencingCarter is only checking immediate dependencies. As soon as I added a direct project reference from Carter.SirenNegotiator.Samples to the Carter project in the submodule referenced there, all was well with module registration by scanning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant