Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to BaseGrid #13

Open
dougiesquire opened this issue Apr 12, 2024 · 0 comments
Open

Add methods to BaseGrid #13

dougiesquire opened this issue Apr 12, 2024 · 0 comments

Comments

@dougiesquire
Copy link
Collaborator

There are a number of commonly implemented methods that are not in the BaseGrid. Adding these as NotImplemeted methods in BaseGrid will make it clearer what can/should be added to grid types:

  • @classmethod fromfile
  • write - I think it could be a good idea to have just a single write method on each grid type to write the grid nc file(s), with kwargs specifying options for a specific grid type (e.g. whether or not to write a mask file also). This would mean the interface for writing grids would be the same for all files, which is currently not the case (e.g. OasisGrid has write_grids, write_areas and write_masks methods).

Also:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant