Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional parameter to algorithms: Image to compute quality measurements against, per iteration #332

Closed
AnderBiguri opened this issue Sep 23, 2021 · 3 comments

Comments

@AnderBiguri
Copy link
Member

As the title says, this would be a parameter that allows the quality measurement parameters to be computed against a known image, rather than change per iteration.

Something like:

[img, qual] = SIRT(proj,geo,angles, 'QualMeas','RMSE','ground_truth',my_image)

@wahaj
Copy link

wahaj commented Nov 5, 2021

Can I get on this ? Would help me to wrap my head around the project. It seems that the init options argument supports providing an image, do you want to seperate that from opt and make it a separate argument ?
% 'Init': Describes diferent initialization techniques. % 'none' : Initializes the image to zeros (default) % 'FDK' : intializes image to FDK reconstrucition % 'multigrid': Initializes image by solving the problem in % small scale and increasing it when relative % convergence is reached. % 'image' : Initialization using a user specified % image. Not recomended unless you really % know what you are doing.

@AnderBiguri
Copy link
Member Author

AnderBiguri commented Nov 5, 2021

Hi @wahaj , absolutely, all yours ;)

I think the best way would be to have a separate argument. Mostly because it should be possible to have both, an image to initialize your algorithm with and an image to compare your results to, and those images be different.

I suggest calling this new argument 'ground_truth', or something like that. Happy to get name suggestions! Perhaps we could also throw an warning if the user has not chosen to call the function with several outputs (nargout), so they know the input is being ignored.

@AnderBiguri
Copy link
Member Author

This already exists in MATLAB, only needed in python now. Closing as duplicate of #410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants