Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoice classes should not modify or reassign self.data #111

Open
QuanMPhm opened this issue Nov 7, 2024 · 0 comments · May be fixed by #119
Open

Invoice classes should not modify or reassign self.data #111

QuanMPhm opened this issue Nov 7, 2024 · 0 comments · May be fixed by #119
Assignees

Comments

@QuanMPhm
Copy link
Contributor

QuanMPhm commented Nov 7, 2024

Currently, all Invoice subclasses reassign self.data before exporting their internal dataframes. This reassignment is done mostly because each invoice only needs to export certain columns. While this step does not change the internal dataframe's data, and has no unwanted side effects, it's presence still raises unwanted ambiguity, and goes against our belief that the Invoice subclasses should not modify their given dataframes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant