fix: Update publish flow #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use environment variable names instead of actual values in setup-java - make actual values accessible only at deploy step - add configuration to `maven-gpg-plugin` to ensure passphrase is provided directly from an environment variable
martinalbert
force-pushed
the
fix/use-gpg-properly
branch
from
7beed0f
to
7ecd255
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR fixes the publish workflow with following changes:
1. use environment variable names instead of actual values in setup-java
This is needed due to generation of
settings.xmlwithin setup-java action. We want to have the xml file in format to contain credentials as:<username>${env.OSSRH_USERNAME}</username>not as:
<username>${env.***}</username>2. make actual values accessible only at deploy step
This ensures we import github secrets as environment variables accessible in
settings.xmlwhich are used by deploy step.3. add configuration to
maven-gpg-pluginto ensure passphrase is provided directly from an environment variableThis is self-describing, adding missing configuration for gpg plugin.