Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement continuous deployment #15

Merged
merged 11 commits into from
Aug 20, 2024

Conversation

martinalbert
Copy link
Contributor

This PR implements workflows for publishing, testing and version control system release-please. It also adds release-please config for proper functioning and basic sanity test.

- consisting of
  - WIP: test workflow
  - publish workflow
  - release-please workflow
- fixing developer connection in scm
- removing activation property from release profile
- formatting
@martinalbert
Copy link
Contributor Author

@Toreno96 @pmiszczak-cksource @zaak Updated the workflows to take in consideration the review. Thanks again. Let me know if it makes sense.

- to correspond with what is needed - instead of username and password - use username and user access token as a password
@Toreno96
Copy link

@Toreno96 Note to self to re-review

Copy link

@Toreno96 Toreno96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 question before I can approve this

.github/workflows/development-tests.yml Show resolved Hide resolved
Copy link

@Toreno96 Toreno96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ViolanteCodes ViolanteCodes merged commit f851c94 into master Aug 20, 2024
4 checks passed
@ViolanteCodes ViolanteCodes deleted the feat/implement-continous-deployment branch August 20, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants