Extended Post Upgrade Testing

[RonTuretzky]

Bug Description

v1.0.3 introduced a bug where a new variable (previousCycleStartingBlock) was introduced but not initialized.

This caused voting power enumerated by the contract for voters post-upgrade to reflect their lifetime bread holdings average, rather than the average held during the previous cycle.

A post-mortem on this was created by @subject026 , with code provided here

project	Current %	Correct %	Diff
labour DAO	26.88	19.76	+7.12%
symbiota	21.08	28.71	-7.63%
cca	7.19	9.65	-2.46%
citizen wallet	9.86	10.12	-0.26%
core	23.53	20.43	+3.10%
treasury	11.43	11.32	+0.10%

The results of this deviation (as of 27.11) are estimated to be in the tens of $BREAD, with some projects benefiting from and some losing from this discrepancy.

Next Steps

• Create an upgrade checklist including checking new variable introduction
• Create a test which simulates an upgrade from the latest tag and goes through a hardcoded flow