Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation as a package #65

Open
1 task
R-Peleg opened this issue Jun 8, 2021 · 2 comments
Open
1 task

Installation as a package #65

R-Peleg opened this issue Jun 8, 2021 · 2 comments

Comments

@R-Peleg
Copy link

R-Peleg commented Jun 8, 2021

As a team, I want to filter pages based on this classifier from code so that we can downstream-process only relevant features.
For that, we would like to install eyeballer as a Python package, either with pip install or by running setup.py

Overview

A setup.py file that will install the package on the system

Thank you a lot for this project.

Acceptance Criteria

  • Security implications approved
  • [ ]

Non Functional Requirements/Wants

  • [ ]

Screenshots / Files

External Documents / Links

@dan-bishopfox
Copy link
Member

Why do you need eyeballer as a package to do that, though? Sounds like you just want to use the tool, why not just use the tool? It can output a JSON blob of the results for you.

@R-Peleg
Copy link
Author

R-Peleg commented Jun 9, 2021

I am using it from Python. True, I can use Subprocess.call(), but this is considered non-optimal.
Moreover, the usage will happen from within a virtual environment, so a package installation will enable us just to add a line to requirement.txt instead of custom installation commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants