Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sticker scripts to new hexSticker version #23

Open
jorainer opened this issue Mar 21, 2017 · 10 comments
Open

Update sticker scripts to new hexSticker version #23

jorainer opened this issue Mar 21, 2017 · 10 comments

Comments

@jorainer
Copy link
Collaborator

The last changes to hexSticker (see issue GuangchuangYu/hexSticker#6) break (almost?) all R scripts to create the stickers.

Update the scripts to create the stickers using the new hexSticker package.

@GuangchuangYu
Copy link
Contributor

sorry, should be the last time.

@GuangchuangYu
Copy link
Contributor

GuangchuangYu commented Mar 21, 2017

maybe wait a second. Let me see if I can add a parameter to switch from different units

@jorainer
Copy link
Collaborator Author

No prob @GuangchuangYu - that's what can be expected when using a devel version.

@GuangchuangYu
Copy link
Contributor

@jotsetung I use npc, see https://github.com/GuangchuangYu/ggimage/blob/master/R/geom_subview.R#L41-L44. The width and height are expected to be in proportion to the plot.

It seems the npc is actually native (maybe a bug), so width and height work as in native unit.

## make no sense XD
> require(grid)
Loading required package: grid
> plot(1:10)
> pushViewport(viewport())
> convertX(unit(.9,"npc"),"native")
[1] 0.9native

please go ahead to update your script 🙈, I have no idea why this happened.

@jorainer
Copy link
Collaborator Author

@GuangchuangYu , you are not changing hexStickers now, are you?

@GuangchuangYu
Copy link
Contributor

@jotsetung no.

jorainer added a commit that referenced this issue Mar 21, 2017
- Adapt the R script to create the AnnotationFilter sticker to the new
  hexStickers package (issue #23).
jorainer added a commit that referenced this issue Mar 21, 2017
- Fix R script to create the FamAgg sticker for hexStickers version 0.1.0 (issue
  #23).
- Small change to AnnotationFilter script.
jorainer added a commit that referenced this issue Mar 21, 2017
- Fix R script to create the mzR sticker for hexStickers version 0.1.0
  (issue #23).
jorainer added a commit that referenced this issue Mar 21, 2017
- Fix R script to create the xcms sticker for hexStickers version 0.1.0
  (issue #23).
@jorainer
Copy link
Collaborator Author

OK, fixed all of my stickers.
@lgatto, should I keep the issue open until you fixed yours?

@GuangchuangYu
Copy link
Contributor

with new version, it is easier to generate treeio sticker.

@GuangchuangYu
Copy link
Contributor

updated s_width = original s_width * sqrt(3)
updated s_height = original s_height * 2

@lgatto
Copy link
Collaborator

lgatto commented Mar 21, 2017

@lgatto, should I keep the issue open until you fixed yours?

Leave it for now, I'll close once I get time to update mine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants